craffel / mir_eval

Evaluation functions for music/audio information retrieval/signal processing algorithms.
MIT License
607 stars 114 forks source link

display submodule #28

Closed craffel closed 8 years ago

craffel commented 10 years ago

For making useful qualitative plots for eval-by-eye

bmcfee commented 8 years ago

How about segments and labeled_intervals?

Unrelatedly: I think it actually makes sense to drop property cycling entirely from the labeled-interval display. I think most of the time, what you'd actually want is annotation-level coloring, since height differentiates label. If you have a fixed style for the entire annotation, then overlying two annotations becomes trivial, and intuitively works the way you'd expect most matplotlib routines to.

Similarly, for the segment display, I think it makes more sense to rely on the axes internal fill style cycler, rather than roll our own. This way, if you draw multiple segmentations on the same plot (eg for hierarchies), the cycler maintains state naturally. It also punts the styling decisions upstream to the matplotlib style sheets, so again, things work in a manner which is consistent with the rest of MPL.

I'll have a PR ready shortly, then we can move the discussion over there.

y_labels?

ehh.. y is ambiguous here, in that it can mean target or y-axis (in this case, kinda both).

craffel commented 8 years ago

Moving discussion to #196.