Allow zero tolerance, but issue a warning.

craffel / mir_eval

Evaluation functions for music/audio information retrieval/signal processing algorithms.

MIT License

604 stars 112 forks source link

Allow zero tolerance, but issue a warning. #301

Closed hendriks73 closed 5 years ago

hendriks73 commented 5 years ago

Change as discussed in #300, i.e. following @stefan-balke 's suggestions to allow a tolerance of zero, but issue a warning.

craffel commented 5 years ago

Thanks for this. Going to wait for the Travis fixes before merging. Ping this PR if Travis is working but we haven't merged.

craffel commented 5 years ago

Hey Hendrik, Travis is passing again. This looks good but I think you will have to include a check for the warning in your test. Do you want to add that? That will also retrigger Travis :)

craffel commented 5 years ago

Looks like you have some PEP-8 errors, otherwise looks good.

hendriks73 commented 5 years ago

Lines too long... gee...

craffel commented 5 years ago

Merged, thanks!

hendriks73 commented 5 years ago

Thank you!