Optimise & fix sonification

craffel / mir_eval

Evaluation functions for music/audio information retrieval/signal processing algorithms.

MIT License

588 stars 109 forks source link

Closed leighsmith closed 3 months ago

leighsmith commented 1 year ago

Added test for only sonifying those frequency bands which have energy.
Corrected sonification time_frequency() t_max parameter to match time units in seconds when adjusting intervals, not samples.
Corrected off-by-one comparison of time centers vs. times, further optimised computations in time_frequency.

bmcfee commented 1 year ago

Thanks for this! I'll try to get a look at it before the week is over.

carlthome commented 12 months ago

Any updates on this? Would love to pitch in as needed to make Windows builds pass.

carlthome commented 7 months ago

Do we consider this PR a blocker for an updated PyPI release? Related: https://github.com/craffel/mir_eval/issues/366

bmcfee commented 7 months ago

Sorry, lost the thread on this one over the summer. I think it's mostly fine now except for that threshold point?