search

craffel / pretty-midi

Utility functions for handling MIDI data in a nice/intuitive way.
MIT License
873 stars 151 forks source link

Fluidsynth produces harsh noise #158

Open davidkant opened 5 years ago

davidkant commented 5 years ago

Fluidsynth synthesis sometimes produces loud harsh noise. This happens when accidentally synthesizing midi pitches that are beyond the range of the chosen instrument. The result should be silent but, i'm guessing due to the normalization, this gets turned into pretty brutal noise.

The quickest fix would be implement Issue #151 Normalization by default and let the user deal with it. Although pretty-midi could also do a quick amplitude check before normalizing. Either is fine by me. Just trying to save my students' ears! Or really save them from getting upset with me...

Thank so much! David

craffel commented 5 years ago

PRs are welcome to resolve #151; I'd be happy to have normalization be via a kwarg which is set to False by default.