search

craffel / pretty-midi

Utility functions for handling MIDI data in a nice/intuitive way.
MIT License
856 stars 151 forks source link

Revert "fix type mismatch in `fluidsynth` calling `sfload`" #226

Closed DavidDiazGuerra closed 1 year ago

DavidDiazGuerra commented 1 year ago

Reverts craffel/pretty-midi#221

That PR crashes with the newer versions of pyfluidsynth, it is fixing a bug that was already fixed in pyfluidsynth in 2017.

See https://github.com/craffel/pretty-midi/issues/220#issuecomment-1569634118

craffel commented 1 year ago

Thanks for catching this, but if it truly has to do with pyfluidsynth version then we should probably add an extras_require to setup.py for fluidsynth that pins the acceptable version range.

DavidDiazGuerra commented 1 year ago

Agree! I'll try to find out which one is the oldest pyfluidsynth release that works with this PR and commit an updated setup.py with it.

DavidDiazGuerra commented 1 year ago

I can confirm that this PR works well with any pyfluidsynth>=1.3.1. I really think it should also work with any pyfluidsynth>=1.2.5, but I couldn't test this since those versions seem to not be compatible with my FluidSynth 3 installation.

Should I include pyfluidsynth>=1.3.1 as an extras_require in setup.py or should we wait till someone can test it on pyfluidsynth==1.2.5?

craffel commented 1 year ago

I think 1.3.1 is fine, thanks.

DavidDiazGuerra commented 1 year ago

Done!

craffel commented 1 year ago

Thanks!