Closed yawjalik closed 6 months ago
This is probably my first ever contribution. Any comments or advice will be greatly appreciated!
Thanks for this. Since the original behavior was equivalent to normalize=True
, that should probably be the default to avoid breaking existing code.
Got it, I've changed them to True
by default.
Thanks!
Added
normalize
parameter such that when set toTrue
, hard-normalizes the synthesized output wave to [-1, 1]. Otherwise, divide the wave bylen(self.instruments) * 2^15
to prevent clipping, and lets the user handle accordingly. It is set toFalse
by default. This serves as a starting point for tackling #151 and #158.