search

craft-oa / gdpr-invitation

0 stars 0 forks source link

Names shouldn't be concatenated client-side #17

Closed asmecher closed 1 month ago

asmecher commented 2 months ago

We shouldn't be concatenating names in this code. Names are built in different ways for different languages, and the logic shouldn't be replicated multiple times in the system.

We should consider either having the API provide full names built by a common function in PHP, or if the front end needs to be able to do this, then there should be a common feature to do it in JS.

I checked with Jarda and he prefers name concatenation server-side, with the full name provided by the API. I agree.

withanage commented 1 month ago

Related PRS

asmecher commented 1 month ago

@withanage, is this actually resolved? It looks like the name concatenation is still happening in the same place in what I think is the most recent branch: https://github.com/ipula/ui-library/blob/edfa76db05fc461eeeeb99007893afe2674133c7/src/managers/InvitationManager/InvitationManagerStore.js#L73

ipula commented 1 month ago

@asmecher there is another one I fixed. I will talk about this with Dimithri