withanage
commented
2 weeks ago Question by Devika: How should we allow editing of users?
The current user is invited, change the information or - delete the existing invitation
Jarda
- Change is a new invite, older one will be replaced
- Edit the option itself and make the desired changes
Alec:
Proposals by Jarda adresses the considerations
Decision: Cancel the invitation and create a new invitation
Devika
Edit and display can be as an option for clear display instead of view in the invitations table
Decision: Add a line or a sentence, what happens
Question by Dulip: CSRF token, should be fixed for new users?
Alec
There is a new ticket on this specially for APIs
Solution: Touhidur will take care of this
Alec Edit user in dropdown, should be consinstent with the invitations and current modals
Devika.
- for Existing user: The view remains the same as when inviting a user
-
Option to remove roles needs to be considered as in the invitation
Question by Alec : invitation context, how do we consider general invitations place ?
Jarda
Currently not decided where we will display these tables.
Dimitris.
Invitations already have a type. Invitations of a certain type are filtered already and in the PR
Alec
There needs to be the support to add them as required.
Decision: Specify the type of invitation as mandatory
Dulip general status of multilingualism ?
Alec
Some issues regarding naming , there is no difference between localization and character-encoding.
Solution Devika will add some mockups for multilingualism
Jarda Question about logging for multiple users when the invitation is accepted ?
Dimitris
Uers cannot log in if another user is logged in
Alec
We have to be more strict on security
Decision. The user should be the same if and when the invitation is accepted
Jarda Rendering user tables in legacy-code can be a task for TIB?
Dulip
TIB can take over parts of this work, may need guidance from Jarda once
Alec
The general user API is the best place to modify before looking into the APIs of tables.
Statement by Dimstris JSON API responoses
JSON response changes a little, may need some customization for the Ui library
Next steps to Do
- TIB has to review and do the changes.
- We will meet in the second week of September
Agenda
API validation mechanism https://github.com/pkp/pkp-lib/discussions/10190
CSRF-Token https://github.com/pkp/pkp-lib/issues/10311
Current bugs/enhancements https://github.com/craft-oa/gdpr-invitation/issues
Possible other areas to consider soon