craft-oa / gdpr-invitation

0 stars 0 forks source link

invitation table -> edit -> invitation add new roles -> save and continue error if there is an already existing user has a wrong start date #34

Closed withanage closed 3 weeks ago

withanage commented 3 weeks ago

Screencast from 26.09.2024 10:19:58.webm

ipula commented 3 weeks ago

this should be fix from backend side. Issue is start date in the already invited role has a previous date.

defstat commented 3 weeks ago

@ipula there is a validation error that checks whether the start date of a role assignment is a "future" date - So if you try to add a user role with a past date, the invitation complains, returning the validation error that you are showing.

When the invitation is accepted, the date assigned to the UserUserGroup is the one defined by the Inviter, even if this is a past date. Here we could implement it differently, assigning the now date for the new userUserGroup, if the invitation defined date is an already past one.

This is implemented this way so that the dispatched invitation does not have a past date for userUserGroup attached to it.