Renaming `panorama` folder in CS2 pak01_dir.vpk freezes the app

craftablescience / VPKEdit

A CLI/GUI tool to create, read, and write several pack file formats.

https://developer.valvesoftware.com/wiki/VPKEdit

MIT License

211 stars 17 forks source link

Renaming `panorama` folder in CS2 pak01_dir.vpk freezes the app #136

Open szmarczak opened 5 months ago

szmarczak commented 5 months ago

Describe the Bug

obraz

To Reproduce

As in the title.

Operating System

Windows 11, VPKEdit v4.2.0

craftablescience commented 5 months ago

To the best of my knowledge it actually does work, it just takes a very long time to complete the operation. So I suggest two things for myself to implement:

Add an indeterminate progress bar to the application when renaming directories, so it doesn't appear to freeze
Change the internal data structure used to hold pack files in memory so renaming directories is quicker

The last one will be a larger refactor, but the first one is easy to do and will be tracked by this issue.

craftablescience commented 4 months ago

Due to some stupid technical nonsense I'm going to have to push this back and only do the second item in that list, which is what the correct fix for the issue is anyways

craftablescience commented 1 month ago

To the best of my knowledge it actually does work, it just takes a very long time to complete the operation. So I suggest two things for myself to implement:

Add an indeterminate progress bar to the application when renaming directories, so it doesn't appear to freeze

Change the internal data structure used to hold pack files in memory so renaming directories is quicker

The last one will be a larger refactor, but the first one is easy to do and will be tracked by this issue.

Done both of these things, but I still need to hook up the fast rename path to the GUI, which is proving a bit more difficult than I thought it would be