craftcms / aws-s3

Amazon S3 volume type for Craft CMS.
https://plugins.craftcms.com/aws-s3
MIT License
61 stars 28 forks source link

Fix web identity check #121

Closed timkelty closed 3 years ago

timkelty commented 3 years ago

Description

https://github.com/craftcms/aws-s3/commit/71e1b3928b4de7c995cdce424c43ac1a773fd880 introduced a regression that would break auth for anyone using credential-less EC2 access.

As-is, credential-less access won't work for anyone (except those using AWS_WEB_IDENTITY_TOKEN_FILE).

Craft::parseEnv expects the $ to be included to parse env vars. Since we're not concerned with alias parsing or normalization, it seems like App::env is a better choice here.

Related issues