S3 Base URL Generation Using Deprecated URL

craftcms / aws-s3

Amazon S3 volume type for Craft CMS.

https://plugins.craftcms.com/aws-s3

MIT License

61 stars 28 forks source link

S3 Base URL Generation Using Deprecated URL #128

Closed iamderrick closed 1 year ago

iamderrick commented 3 years ago

When the plugin automatically tries to generate the base URL for a publically accessible S3 bucket, it uses the old path-style model rather than the new virtual-hosted model. This older URL model does not work with newer S3 buckets. See: https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

andris-sevcenko commented 3 years ago

I personally have no preference here, but you should know that @timkelty will have an opinion.

Context: #34

timkelty commented 3 years ago

Yeah, as long as it's https by default, prob should go with the virtual-hosted version. @iamderrick happy to review a PR, otherwise we'll get to it soon.

brianjhanson commented 1 year ago

It looks like the plans to deprecate the old path-style have been put on pause somewhat indefinitely. Either way, I've opened a PR to address this.

brandonkelly commented 1 year ago

Amazon S3 1.3.1 (Craft 3) and 2.0.2 (Craft 4) are out now, and use the new URL format by default.