craftcms / cms

Build bespoke content experiences with Craft.
https://craftcms.com
Other
3.22k stars 626 forks source link

[4.x]: Overlay drop shadows don't disappear #13016

Open freder opened 1 year ago

freder commented 1 year ago

What happened?

Description

looks like overlays won't get removed from the dom after they were closed.

Screenshot 2023-03-29 at 23 23 02

Steps to reproduce

  1. open and close a bunch of overlays (for editing related entries)

Expected behavior

shadows should disappear

Actual behavior

see screenshot

Craft CMS version

4.4.5

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

-

i-just commented 1 year ago

Hi, thanks for reaching out. I’m having trouble replicating this behaviour. Could you please let me know what browser and OS you’re on?

freder commented 1 year ago

craft-commerce-shadow

i-just commented 1 year ago

Thanks! Could you please share a list of plugins you’re using? We’re still unable to replicate this on a clean Craft 4 installation.

brandonkelly commented 1 year ago

Also, are you seeing any JavaScript errors on the page, when closing the slideout?

freder commented 1 year ago

no errors in the console, but a bunch of elements keep getting appended:

Screenshot 2023-04-04 at 11 25 31

plugins

brandonkelly commented 1 year ago

Can you send in your Composer files, config/project/ folder, and any custom module/plugin code you’re running, to support@craftcms.com? We can try to look into it using the same exact code + dependencies, and see if that helps.

freder commented 1 year ago

freder commented 1 year ago

did some more testing: I have the same issue on (vanilla) firefox and safari. however, it's all fine in chrome and firefox on linux.

freder commented 1 year ago

since this is merely cosmetic, I'd say don't spend any more time on this for now. – maybe check out https://github.com/craftcms/commerce/pull/3130 instead ;)