[4.x]: Image dimensions null when expected memory usage exceeds the limit

jeroenverfallie commented 1 year ago

What happened?

Description

Given an image with a large dimension (for example 8000x9500) the Raster->loadImage() method returns a memory exception. This causes the image to exists in the database with a width & height being null.

https://github.com/craftcms/cms/blob/develop/src/image/Raster.php#L163-L166

Expected behavior

Even if craft is unable to produce the cp image transforms, we'd expect the dimensions of the original image to be available, as loading these is a low-cost operation. In fact, the method used to calculate the expected memory usage (getimagesize()) offers the dimensions by itself.

Craft CMS version

4.4.17

PHP version

8.1

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

-

i-just commented 1 year ago

Hi, thanks for reaching out.

Could you please confirm your image driver and post the error from your logs?

I was able to replicate this behaviour when using imagick (gd seems to handle the same large images well), though not caused by the lines you linked to.

The error I ran into was internal to ImageMagick. I made some changes to improve logging around what’s happening, and we’ll also have an internal discussion about this.

stijntilleman commented 11 months ago

Hi @i-just,

we've added the extra logging mentioned in pr https://github.com/craftcms/cms/pull/13694 to the project @jeroenverfallie mentioned above.

When using the imagick driver we get an extra log entry but the image is uploaded to the website

2023-09-26 14:29:21 [web.WARNING] [craft\helpers\Image::imageSize] Not enough memory available to perform this image operation. {"memory":6769504}

When we switched to the gd driver

no log entry
the uploader gets a flash message Not enough memory available to perform this image operation
the image is not uploaded to the website

Completing the information provided by jeroen