search

craftcms / cms

Build bespoke content experiences with Craft.
https://craftcms.com
Other
3.22k stars 627 forks source link

Asset bundles apparently still loaded from disabled plugin #3961

Closed narration-sd closed 5 years ago

narration-sd commented 5 years ago

I got a surprise, with a plugin having only some Events and an Asset Bundle. The Asset Bundle was targeted at some Garnish code, and had some console.log()s in it to monitor the purpose.

The surprise was to see those loggings coming through after disabling the plugin, indicating also that I was still fooling around with Garnish.

I could pull the plugin out with composer, but I think it's evident any mod on CP code that lingers after plugin disable could cause problems,

It's not an immediate problem here, or for upcoming beta, but could be on a planned upgrade in other peoples' hands.

narration-sd commented 5 years ago

closing for the moment, as this is very strange. I've removed the plugin via composer, and the messaging is still there. Cleared caches, destroyed cpresources, grepped /vendor and actually the whole site.

It's as if the asset js has transmigrated into the database, or something; seems the only thing left.

I am sure to be back about this one.

narration-sd commented 5 years ago

Ok, this is solved fully.

I had trialed this code originally using doublesecretagency/craft-cpjs (thanks, @lindseydiloreto ! )

And that plugin and its code load was still in there, yes in the database through its settings....so what I saw wasn't coming from my disabled/then-removed extra plugin after all.

Quite ok to call the trucks back, and firepersons put their feet up...

(we had a house fire in neighborhood two nights ago, great response)