search

craftcms / cms

Build bespoke content experiences with Craft.
https://craftcms.com
Other
3.29k stars 638 forks source link

CMS Utilities Updates page no longer showing updates [Firefox] #5321

Open qrazi opened 4 years ago

qrazi commented 4 years ago

Description

When trying to see available updates, the loading icon just keeps indicating loading. The inspector shows a JavaScript error.

Steps to reproduce

  1. Clean install Craft CMS 3.3.17
  2. Login CMS
  3. Go to Utilities -> Updates
  4. See "Checking for updates..." plus loading icon
  5. Open browser inspector
  6. See "TypeError: e.updates is undefined" in UpdatesUtility.js:29:24

Additional info

Edit: Just now figured out this is an issue with at least Firefox Developer Edition 72.0b4, the issue cannot be reproduced in Chrome 78.0.3904.108

brandonkelly commented 4 years ago

I’m not able to reproduce this with the same browser/version. Any chance you can send an admin account’s credentials, plus SSH access, over to support@craftcms.com?

qrazi commented 4 years ago

Let me setup the clean install on one of my droplets and try and reproduce there. As you could not reproduce, this could very well be an issue with one of my add-ons, one of the ad-blockers perhaps.

qrazi commented 4 years ago

Ok, it turned out to indeed be one of my ad-blockers, EFF's Privacy Badger addon. The default setting for the https://api.craftcms.com domain for me was set to blocking:

image

Changing the setting to "only block cookies, but not the actual requests" (middle slider setting) is enough to have the update page working again... So, not an issue with Craft CMS

Edit: I'll check what I can do with https://www.eff.org/privacybadger/faq#Does-Privacy-Badger-contain-a-%22black-list%22-of-blocked-sites

brandonkelly commented 4 years ago

I suspect this is due to the Google Analytics tracking cookie that you get when visiting https://craftcms.com. Looking into how to get that cookie domain to be just craftcms.com instead of .craftcms.com, but GA seems a little insistent on adding that ., even if I explicitly set cookieDomain: 'craftcms.com'.