craftcms / cms

Build bespoke content experiences with Craft.
https://craftcms.com
Other
3.28k stars 635 forks source link

Asset modal positions off the page on small (non-mobile) displays #7252

Open rickmills opened 3 years ago

rickmills commented 3 years ago

Description

The admin asset modal that pops up when adding an image via the wysiwyg, or selecting an asset has a tendancy to drop down too low on some displays.

We've had two separate clients experience this (Both using fairly recent versions of MS Edge) and I've been able to replicate it by making my browser window ~600 px high.

It looks like there may be two problems however.

I also suspect this gets worse with the more files and sidebar directories you have as this extends the height even more.

I've included some examples at the bottom of this task to show the issue, including a screenshot sent over by a client using the latest version of craft as of writing (3.5.16).

There is an argument that you can't expect it to work if the height is very low - which is a valid point, but given many businesses currently have employees working from things like 11" chromebooks at home, which have a resolution of 1366 x 768 it really should be possible to use it on these - currently the modal starts cutting off at around 815px height.

Steps to reproduce

  1. Open a browser - any browser, and go to an entry
  2. Open the insert image modal on the wysiwyg
  3. Start resizing your browser, reducing its height but not width
  4. Eventually the modal will be dropped out of view

Additional info

Examples

Screenshot 2020-12-11 at 10 54 58

Screenshot 2020-12-11 at 11 01 36

brandonkelly commented 3 years ago

Check your JavaScript console – are any errors logged in there when this happens?