search

craftcms / commerce

Fully integrated ecommerce for Craft CMS.
https://craftcms.com/commerce
Other
219 stars 170 forks source link

Don't send Discount Name to gateways #1117

Open engram-design opened 4 years ago

engram-design commented 4 years ago

At the moment, when sending orders (with PayPal, but probably others - anything using https://github.com/craftcms/commerce-omnipay), if the order includes a discount, it uses both the name and description in the order details.

This is fine, but the field instructions in the CP clearly state that the name is what its referred to the CP, which is kind of inferring that its not shown to customers. As such, our clients are using this to store non-customer facing info, but its being shown regardless.

See https://d.pr/free/i/kaA1XE

Note I've tweaked the instruction text on the second field for clarity for this client.

Unsure if it a change in https://github.com/craftcms/commerce-omnipay/blob/master/src/base/Gateway.php#L704-L705 or clarifying the field instructions?

gojira32 commented 4 years ago

@lukeholder Any update on this?

lukeholder commented 3 years ago

https://linear.app/craftcms/issue/COM-35/fix-field-descriptions-on-all-namedescription-fields-for-discounts