craftcms / commerce

Fully integrated ecommerce for Craft CMS.
https://craftcms.com/commerce
Other
225 stars 170 forks source link

Example template doesn't check shipping method before asking it's name. #2546

Closed aeu closed 3 years ago

aeu commented 3 years ago

Description

In the example template files, the order summary doesn't check to see if there's a shipping method before asking it's cost.

Steps to reproduce

  1. Create a store
  2. Install sample templates
  3. Step through checkout without picking a shipping method
  4. Site crashes.

Additional info

nfourtythree commented 3 years ago

Hi @aeu

I have just installed a fresh version of Craft and Commerce, used the ./craft commerce/example-templates to copy over the example templates and was able to step through the checkout without any problems.

Where there any other steps that I would need to take to replicate the issue you had? A specific shipping method setup or any other settings? Were you using Commerce Pro or Lite?

Thanks.

aeu commented 3 years ago

Hi @nfourtythree

I'm using Pro, and Postie.

nfourtythree commented 3 years ago

Hi @aeu

Thank you for your reply. I am still unable to replicate the issue you described.

You mentioned the "site crashes" could you please send over a stack trace or error log when this happens.

This could help identify if something strange is happening.

Thanks!

aeu commented 3 years ago

Hi @nfourtythree

I didn't screenshot it unfortunately, the page just throws an exception, shipping not defined, or something along those lines, similar to what you get when you access a null variable.

nfourtythree commented 3 years ago

Hi @aeu

Thanks for that info. Unfortunately without a way of reliably replicating the issue there is not really much we can do.

For the moment, I will close this issue. If you find a way to reliable reproduce the error or have a stack trace for it please add a comment here and I can reopen the issue.

Thanks!