search

craftcms / commerce

Fully integrated ecommerce for Craft CMS.
https://craftcms.com/commerce
Other
217 stars 170 forks source link

[4.x]: Unset variables in toast message when updating order status #3116

Closed jonleverrier closed 1 year ago

jonleverrier commented 1 year ago

What happened?

Description

When the status of an order is changed from one to another, the toast message displays variables with no values set.

Screenshot 2023-03-15 at 16 46 21

Steps to reproduce

  1. Go to Orders in the Commerce CP
  2. Select an order from the table and, as of Craft CMS v4.4, click on the cog at the bottom of the table
  3. Click on Update Order Status and change the status from one value to another
  4. The toast message appears with variables which are not set

Expected behavior

For variables in the toast message to display when an order has its order status changed

Actual behavior

Variables in the toast message are not set when an order has its order status changed (see screenshot above)

Craft CMS version

v4.4.2

Craft Commerce version

4.2.5.1

PHP version

8.0.21

Operating system and version

Linux 5.15.49-linuxkit

Database type and version

MariaDB 10.4.25

Image driver and version

Imagick 3.6.0 (ImageMagick 6.9.11-60)

Installed plugins and versions

-

nfourtythree commented 1 year ago

Hi @jonleverrier

Thank you for highlighting this.

We have pushed a fix which will be included in the next release of Commerce.

Thanks!

lukeholder commented 1 year ago

This is now fixed and in the 4.2.6 release of Commerce. Thanks.