craftcms / commerce

Fully integrated ecommerce for Craft CMS.
https://craftcms.com/commerce
Other
215 stars 169 forks source link

[5.x]: store location edit button does not open slideout by default #3536

Closed piotrpog closed 2 weeks ago

piotrpog commented 3 weeks ago

What happened?

Description

In store management/general we have list of locations. After clicking three dots next to the location and selecting "edit" i expected slideout to open. But instead i was moved to separate page.

Craft CMS version

5.1.1.0

Craft Commerce version

5.0.9

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

-

linear[bot] commented 3 weeks ago

PT-1807 [5.x]: store location edit button does not open slideout by default

nfourtythree commented 3 weeks ago

Hi @piotrpog

Thank you for your message.

Is this for editing the store location or the inventory locations associated to the store?

Thanks.

piotrpog commented 2 weeks ago

This would be store locations - store managment/general, clicking three dots and selecting "edit". I expected this should trigger slideout.

image

nfourtythree commented 2 weeks ago

Hi @piotrpog

Clicking edit next to Store Location (as you said in your message) seems to work as expected for me.

https://github.com/craftcms/commerce/assets/266453/8e02c65a-e6ac-4d35-8721-1b5df425b92e

Thanks

piotrpog commented 2 weeks ago

@nfourtythree How about on the bottom of this page, under "inventory locations" header, in "default" tile?

nfourtythree commented 2 weeks ago

HI @piotrpog

Ah so you are looking at the inventory locations.

These are specifically designed to not open in a slide out. This is the same reason why they have their own side bar navigation item.

Inventory locations are not owned by any one particular store but rather just associated with which ever stores used them. For this reason we opted not to have a slide out to avoid any confusion to when editing this data, by taking the user to the specific edit page this is to show that the changes you are making are not for one specific store but global across the system.

Hope this helps, thanks!

piotrpog commented 2 weeks ago

@nfourtythree Thank you for the explanation.