[4.x]: 4.10.0 won't start with Commerce installed

[boboldehampsink]

What happened?

Description

When upgrading to 4.10.0, I see the following error appear in all my Commerce installations:

> populating the info table ... done
--
  | 2024-06-14 06:16:20 UTC | Exception: craft\helpers\Db::uidById(): Argument craftcms/cms#2 ($id) must be of type int, null given, called in /app/user/vendor/craftcms/commerce/src/services/ProductTypes.php on line 926 (/app/user/vendor/craftcms/cms/src/helpers/Db.php:1370)
  | 2024-06-14 06:16:20 UTC | #0 /app/user/vendor/craftcms/commerce/src/services/ProductTypes.php(926): craft\helpers\Db::uidById('{{%sites}}', NULL)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#1 [internal function]: craft\commerce\services\ProductTypes->afterSaveSiteHandler(Object(craft\events\SiteEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#2 /app/user/vendor/yiisoft/yii2/base/Event.php(312): call_user_func(Array, Object(craft\events\SiteEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#3 /app/user/vendor/yiisoft/yii2/base/Component.php(650): yii\base\Event::trigger('craft\\services\\...', 'afterSaveSite', Object(craft\events\SiteEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#4 /app/user/vendor/craftcms/cms/src/services/Sites.php(824): yii\base\Component->trigger('afterSaveSite', Object(craft\events\SiteEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#5 /app/user/vendor/craftcms/cms/src/base/ApplicationTrait.php(1856): craft\services\Sites->handleChangedSite(Object(craft\events\ConfigEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#6 /app/user/vendor/craftcms/cms/src/services/ProjectConfig.php(1159): craft\console\Application->craft\base\{closure}(Object(craft\events\ConfigEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#7 [internal function]: craft\services\ProjectConfig->handleChangeEvent(Object(craft\events\ConfigEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#8 /app/user/vendor/yiisoft/yii2/base/Component.php(641): call_user_func(Array, Object(craft\events\ConfigEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#9 /app/user/vendor/craftcms/cms/src/models/ProjectConfigData.php(82): yii\base\Component->trigger('addItem', Object(craft\events\ConfigEvent))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#10 /app/user/vendor/craftcms/cms/src/services/ProjectConfig.php(703): craft\models\ProjectConfigData->commitChanges(NULL, Array, 'sites.3a93c888-...', false, NULL, true)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#11 /app/user/vendor/craftcms/cms/src/helpers/ProjectConfig.php(145): craft\services\ProjectConfig->processConfigChanges('sites.3a93c888-...', true)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#12 /app/user/vendor/craftcms/cms/src/migrations/Install.php(1112): craft\helpers\ProjectConfig::ensureAllSitesProcessed(true)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#13 /app/user/vendor/craftcms/cms/src/migrations/Install.php(82): craft\migrations\Install->insertDefaultData()
  | 2024-06-14 06:16:20 UTC | craftcms/cms#14 /app/user/vendor/craftcms/cms/src/db/Migration.php(50): craft\migrations\Install->safeUp()
  | 2024-06-14 06:16:20 UTC | craftcms/cms#15 /app/user/vendor/craftcms/cms/src/db/MigrationManager.php(233): craft\db\Migration->up(true)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#16 /app/user/vendor/craftcms/cms/src/console/controllers/InstallController.php(214): craft\db\MigrationManager->migrateUp(Object(craft\migrations\Install))
  | 2024-06-14 06:16:20 UTC | craftcms/cms#17 [internal function]: craft\console\controllers\InstallController->actionCraft()
  | 2024-06-14 06:16:20 UTC | craftcms/cms#18 /app/user/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#19 /app/user/vendor/yiisoft/yii2/base/Controller.php(178): yii\base\InlineAction->runWithParams(Array)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#20 /app/user/vendor/yiisoft/yii2/console/Controller.php(180): yii\base\Controller->runAction('', Array)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#21 /app/user/vendor/craftcms/cms/src/console/ControllerTrait.php(90): yii\console\Controller->runAction('', Array)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#22 /app/user/vendor/craftcms/cms/src/console/Controller.php(216): craft\console\Controller->traitRunAction('', Array)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#23 /app/user/vendor/yiisoft/yii2/base/Module.php(552): craft\console\Controller->runAction('', Array)
  | 2024-06-14 06:16:20 UTC | craftcms/cms#24 /app/user/vendor/yiisoft/yii2/console/Application.php(180): yii\base\Module->runAction('install', Array)
  | 2024-06-14 06:16:20 UTC | #25 /app/user/vendor/craftcms/cms/src/console/Application.php(91): yii\console\Application->runAction('install', Array)
  | 2024-06-14 06:16:20 UTC | #26 /app/user/vendor/yiisoft/yii2/console/Application.php(147): craft\console\Application->runAction('install', Array)
  | 2024-06-14 06:16:20 UTC | #27 /app/user/vendor/craftcms/cms/src/console/Application.php(122): yii\console\Application->handleRequest(Object(craft\console\Request))
  | 2024-06-14 06:16:20 UTC | #28 /app/user/vendor/yiisoft/yii2/base/Application.php(384): craft\console\Application->handleRequest(Object(craft\console\Request))
  | 2024-06-14 06:16:20 UTC | #29 /app/user/craft(19): yii\base\Application->run()
  | 2024-06-14 06:16:20 UTC | #30 {main}
  | 2024-06-14 06:16:20 UTC | *** failed to install Craft: An error occurred while executing the "craft\migrations\Install migration: craft\helpers\Db::uidById(): Argument craftcms/cms#2 ($id) must be of type int, null given, called in /app/user/vendor/craftcms/commerce/src/services/ProductTypes.php on line 926

Steps to reproduce

1. This is when trying to upgrade an existing site to 4.10

Craft CMS version

4.10.0

PHP version

8.3

Operating system and version

No response

Database type and version

Postgres

Image driver and version

No response

Installed plugins and versions

Commerce 4.6.2

[linear[bot]]

PT-1836 [4.x]: 4.10.0 won't start with Commerce installed