craftcms / commerce

Fully integrated ecommerce for Craft CMS.
https://craftcms.com/commerce
Other
215 stars 169 forks source link

[5.x]: Required custom order field not validated when posting to /commerce/cart/update-cart #3552

Closed MatthiasBrodelet closed 1 week ago

MatthiasBrodelet commented 1 week ago

What happened?

Description

I have created a custom order field with handle telephoneNumber. This has been set to required in the field layout. However when posting from the front end the field does not throw any errors when left empty. If I enter a value it does save correctly to the cart / order so that part seems to work fine.

Steps to reproduce

  1. Create custom order field
  2. Set as required
  3. Add it to the HTML with name fields[telephoneNumber]
  4. Post form to /commerce/cart/update-cart

Expected behavior

The field should be validated

Actual behavior

I am able to bypass the required field

Craft CMS version

Craft CMS 5.2.3

Craft Commerce version

5.0.11.1

PHP version

8.2.17

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

-

linear[bot] commented 1 week ago

PT-1884 [5.x]: Required custom order field not validated when posting to /commerce/cart/update-cart

lukeholder commented 1 week ago

Make sure the validateCartCustomFieldsOnSubmission setting is set to true.