craftcms / commerce

Fully integrated ecommerce for Craft CMS.
https://craftcms.com/commerce
Other
226 stars 170 forks source link

[5.x]: No permissions for "Donations" page #3647

Closed MatthiasBrodelet closed 1 month ago

MatthiasBrodelet commented 2 months ago

What happened?

Description

I have some user roles that just need to handle the products so I have only enabled this permission for this role but the donations page still is accessible in the sidebar under "Commerce". Can this also be added as a permission? My editors are confused and can now enable or disable donations while we don't use them.

Screenshot 2024-08-29 at 10 40 37

Steps to reproduce

  1. Try to remove the permissions for the donations page

Expected behavior

Donations should not be shown in the sidebar if the permission is not given.

Actual behavior

Everyone can see the donations page in the sidebar when they have 1 or more Commerce permission

Craft CMS version

5.x

Craft Commerce version

5.x

PHP version

8.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

-

linear[bot] commented 2 months ago

PT-2123 [5.x]: No permissions for "Donations" page

lukeholder commented 1 month ago

This is fixed in Craft Commerce 5.1.0-beta.3.

The proper 5.1 release will be out of beta within a few days. Thanks!