search

craftcms / feed-me

Craft CMS plugin for importing entry data from XML, RSS or ATOM feeds—routine task or on-demand.
Other
288 stars 139 forks source link

SuperTable fields don't get filled in under certain conditions. #1392

Open anvart opened 9 months ago

anvart commented 9 months ago

Description

I've got a section with SuperTalbe field which has all kind of (text, lightswitches, datetime, entry) non-mandatory sub-fields. This condition (took me some time to spot): https://github.com/craftcms/feed-me/blob/1d774e0c85e20c1eb57710de659510ed9a3296ea/src/fields/SuperTable.php#L151 ignores things like Carbon\Carbon So if there are only Date fields in a ST row, it won't get filled in.

Steps to reproduce

  1. Create a section with a SuperTable field which would only contain DateTime sub field(s)
  2. FeedMe it with anything
  3. Get no rows

Additional info