craftcms / feed-me

Craft CMS plugin for importing entry data from XML, RSS or ATOM feeds—routine task or on-demand.
Other
288 stars 139 forks source link

Convert to Yii log targets and use DbTarget #1462

Closed timkelty closed 3 months ago

timkelty commented 3 months ago

Description

Related issues

Fixes https://github.com/craftcms/feed-me/issues/1344

timkelty commented 3 months ago

@angrybrad should be ready:

dgsiegel commented 1 month ago

@timkelty it looks like that even with your example, logs will always be stored and read from the db. Adding the logging example will additionally log it to a file, correct?

timkelty commented 1 month ago

@dgsiegel That's correct.

dgsiegel commented 1 month ago

@timkelty in that case I'd urge you to review this merge request. Feed Me is quite noisy in its default configuration, and unless you set logging to false or error, that table will grow considerably if you import lots of items (10k+) regularly (few times per day).

Additionally, the README in its current form suggests that you are able to replace the default logging mechanism (and therefore also displaying the latest log entries in the UI), which is not the case.