search

craftcms / google-cloud

Google Cloud Storage volume type for Craft CMS.
https://plugins.craftcms.com/google-cloud
MIT License
11 stars 10 forks source link

Plugin Broken: Volume.php does not implement a validate method #4

Closed Yugloocamai closed 5 years ago

Yugloocamai commented 5 years ago

I'm not sure how this plugin can work with Craft without a validate method. It does not work for me. When Craft3 calls saveVolume, it calls the validation method which will always return null since the method is not implemented. Perhaps Craft3 added that step recently?

        if ($runValidation && !$volume->validate()) {
            Craft::info('Volume not saved due to validation error.', __METHOD__);
            return false;
        }
andris-sevcenko commented 5 years ago

The method is implemented in yii\base\Model, from which the craft\googlecloud\Volume inherits it.

Yugloocamai commented 5 years ago

It looks like the validation error is actually Bucket cannot be blank., but the toast message on the front end is just Couldn’t save volume. I think the real issue here might just be messaging.

andris-sevcenko commented 5 years ago

Ah, nice find! Fixed for next release.