Windows hosts file editing steps missing for `create` and `add` commands

mattstein commented 3 years ago

Description

These really good docs promise Nitro will output steps for manually editing etc\hosts in Windows:

Nitro commands that want to edit that file will give you the steps so you can manually perform the edit.

This is true only for the apply command, but not when running create or add. I would expect that Nitro would output these steps any time hostnames need to be updated, regardless of the command used.

Steps to reproduce

Install Nitro for Windows.
Use nitro create, follow the prompts, and note the steps end with the following output:
```
Adding sites to hosts file…
  … modifying hosts file ✓
```
Use nitro edit to save a change to nitro.yaml, then run nitro apply.
Observe the resulting output includes the promised instructions fenced with ---- COPY BELOW ---- and ---- COPY ABOVE ----.

Additional info

Nitro version: 2.0.4
Docker version: 20.10.2, build 2291f61
Windows version: Windows 10 Pro 19041.804
WSL2 Distro: Ubuntu 20.04 LTS

jasonmccallister commented 3 years ago

I’m pretty sure I know what this is and will look into it soon.

jamesmacwhite commented 3 years ago

Hopefully if possible and based on further investigation, the ambition in the future would be for Nitro to be able to commit the /etc/hosts content directly to the Windows system hosts file too, as the /mnt/c/ path is exposed through WSL, the only caveat is an elevated WSL terminal is needed to be able to do this, as even with sudo without the process being elevated to begin with from the Windows host, a file write is not possible from within WSL.

https://github.com/craftcms/nitro/issues/258

craftcms / nitro