alias command allows spaces in list of hostnames. Different validators for hostname and list of hostnames

craftcms / nitro

Speedy local dev environment for @craftcms.

https://getnitro.sh

MIT License

178 stars 24 forks source link

alias command allows spaces in list of hostnames. Different validators for hostname and list of hostnames #330

Closed marionnewlevant closed 3 years ago

marionnewlevant commented 3 years ago

Description

Same validate.HostnameValidator was used for comma separated list of hostnames (alias) and for single hostnames.

Factored out the validator for the list of hostnames, and made it slightly more forgiving, so that this.tld, that.dld is a valid list. Added , to the disallowed special characters of the HostnameValidator

Fixed two minor typos

jasonmccallister commented 3 years ago

@marionnewlevant I will look at getting this reviewed/merged soon!

jasonmccallister commented 3 years ago

@marionnewlevant can you change the branch to develop?

marionnewlevant commented 3 years ago

@jasonmccallister My grasp of pull requests is not all it might be. I will try.

jasonmccallister commented 3 years ago

Closing in favor of #341, thank you!!