craftcms / nitro

Speedy local dev environment for @craftcms.
https://getnitro.sh
MIT License
178 stars 24 forks source link

nitro create mixes up PHP version #375

Closed hiasl closed 3 years ago

hiasl commented 3 years ago

Description

I just used nitro create to setup a new project. The setup process worked fine, however the PHP version is somehow mixed up. It should be PHP8, composer.json is locked to 7.2 and the container is running 7.4 (on the nitro composer console).

Steps to reproduce

Installation failed, reverting ./composer.json and ./composer.lock to their original content.



- One additional note: There is only 1 more host in my nitro setup, which was setup with PHP 7.4
- And one more: I tried it a second time, with a different hostname, same thing

### Additional info

- Nitro version: 2.0.8
- Docker version: 20.10.7
jasonmccallister commented 3 years ago

@hiasl the nitro create command will not modify the projects php version, that is stored on the craft project itself here: https://github.com/craftcms/craft/blob/main/composer.json#L37.

Closing this out for now as Nitro is not going to modify the composer.json during the create command.