Bugfix 'opcache_validate_timestamps' isn't set correctly if defined i…

craftcms / nitro

Speedy local dev environment for @craftcms.

https://getnitro.sh

MIT License

178 stars 24 forks source link

Bugfix 'opcache_validate_timestamps' isn't set correctly if defined i… #452

Closed wiljonbolten closed 2 years ago

wiljonbolten commented 2 years ago

…n nitro.yml

Description

When you set opcache_validate_timestamps trough nitro iniset the setting won't be applied to the Docker container. The changes will provide you with a working opcache_validate_timestamps value.

Related issues

ini setting opcache_validate_timestamps doesn't seem to work #435

jasonmccallister commented 2 years ago

🙏 thank you @wiljonbolten!

wiljonbolten commented 2 years ago

No problem @jasonmccallister! Think I made a mistake in adding it to the test, will take a look into it very soon.

jasonmccallister commented 2 years ago

Thanks! Will try to get it merged when its resolved!

wiljonbolten commented 2 years ago

Looks like a typo (unwanted }) was causing the issue. Unfortunately can't perform the tests without errors on my local environment (production and my own branch), probably because of not retrieving an correct editor in the test TestGetPreferredEditorFromEnvironment.

Nevertheless, removing the extra unwanted character should have fixed it now.

jasonmccallister commented 2 years ago

💯 thank you again for this @wiljonbolten!