craftcms / nitro

Speedy local dev environment for @craftcms.
https://getnitro.sh
MIT License
178 stars 24 forks source link

`.env` is not updated during `nitro create` #464

Closed tommysvr closed 2 years ago

tommysvr commented 2 years ago

Description

The 'Update .env' step of nitro create appears to work, but nothing is actually written to .env due to these changes: https://github.com/craftcms/craft/commit/34e84a1edb6af4fd1ec59bce45060f5e1f6e807c

Steps to reproduce

  1. Run nitro create
  2. Say yes to 'Should we update the env file? [Y/n]'
  3. '.env updated!' will show but if you check .env the default settings remain

Additional info

https://github.com/craftcms/nitro/blob/develop/command/create/create.go#L143

jasonmccallister commented 2 years ago

@tommysvr sorry will close this when we cut a release!

jasonmccallister commented 2 years ago

Just tagged 2.0.10 with this change!