search

craftcms / plugin-installer

Composer installer for Craft CMS plugins.
MIT License
28 stars 3 forks source link

Take composer version aliases into account when setting plugin version #8

Closed boboldehampsink closed 2 years ago

boboldehampsink commented 3 years ago

Take composer version aliases into account when setting plugin version. This will fix many issues that I have when requiring forks that have a dev-x version in composer. Example:

"craftcms/commerce": "dev-bugfix/payment-currency-convert as 3.3.4.1", saves dev-bugfix/payment-currency-convert as the plugins' version. In commerce itself, there is a lot of version_compare going on which doesn't play nice with this logic.

So there is really no way for me now to load a commerce fork...

brandonkelly commented 2 years ago

Not possible, unfortunately (see https://github.com/composer/composer/issues/9467).