Closed khalwat closed 2 years ago
TomasVotruba
commented
2 years ago Thanks for repoting :+1:
That's because craftcms/rector uses Rector in dev-main: https://github.com/craftcms/rector/blob/990d30d4657cee599b7bcb013b921c4da6faae6c/composer.json#L6
You can require it in your package, or wait for my fix :+1:
khalwat
commented
2 years ago Do you think craftcms/rector should be using a tagged release in its composer.json @TomasVotruba ?
TomasVotruba
commented
2 years ago Let's try: https://github.com/craftcms/rector/pull/6 Looking at your report again, it might be not enough though. Could you verify?
Do you think craftcms/rector should be using a tagged release in its composer.json @TomasVotruba ?
Definitelly on require section, so people don't have issue you've reported.
TomasVotruba
commented
2 years ago Btw, even your PHP version does not match the requirements:
- codeception/module-datafactory 1.0.0 requires php >=5.6.0 <8.0 -> your php version (8.0.13) does not satisfy that requirement.You'll need to upgrade codeception to PHP 8.0+ version first.
khalwat
commented
2 years ago It's PHP 8.0.13 already... your php version (8.0.13)
TomasVotruba
commented
2 years ago Could you share exact copy-paste steps to reproduce in bash on PHP 8.0? I'll try locally
TomasVotruba
commented
2 years ago Yeah, the PHP version is ok. But the codeception is old:
khalwat
commented
2 years ago I'm using the Codeception versions that Craft CMS has pinned (linked in the initial post) in their actual composer.json files in craftcms/cms. So I'm using what P&T is using for Craft CMS currently.
All of this worked without issue until the recent PR, so I'm thinking that's the issue.
As for running it locally, absolutely! Just fire up this project:
TomasVotruba
commented
2 years ago I'm using the Codeception versions that Craft CMS has pinned (linked in the initial post) in their actual composer.json files in craftcms/cms. So I'm using what P&T is using for Craft CMS currently.
It's also possible the patch version of codeception can support PHP 7 or 8, depending on exact patch version of another dependency :) I've seen some similar mess in such project lacking united monorepo versioning.
As for running it locally, absolutely! Just fire up this project:
Thanks. It seems it requires Docker, but I don't use it: I'll need something simple as "git clone/composer require", so we can test it in CI here to confirm it works in the long run.
khalwat
commented
2 years ago Thanks. It seems it requires Docker, but I don't use it:
It's an easy install if you want to test it: https://docs.docker.com/desktop/
I'll need something simple as "git clone/composer require", so we can test it in CI here to confirm it works in the long run.
It should be as easy as having a composer.json that looks like this:
https://github.com/nystudio107/plugindev/blob/develop/cms_v4/composer.json
...and then doing a composer install
Or you could use the Craft CMS composer.json: https://github.com/craftcms/cms/blob/develop/composer.json
...and add Rector to require-dev:
"craftcms/rector": "dev-main",...and then doing a composer install
TomasVotruba
commented
2 years ago I'm not using Docker on purpose :)
So, something like:
git clone git@github.com:craftcms/cms.git --depth 1
cd cms
composer require craftcms/rector:dev-mainI see it. The private accessor from Symplify :+1:
TomasVotruba
commented
2 years ago
Description
Using these
require-devdependencies for Craft 4: https://github.com/craftcms/cms/blob/develop/composer.json#L67or using these
require-devdependencies for Craft 3: https://github.com/craftcms/cms/blob/v3/composer.json#L61...and then adding
craftcms/rector:...results in:
Your requirements could not be resolved to an installable set of packages.
I believe it's a result of this PR: https://github.com/craftcms/rector/pull/4
...which bumps up the dependencies, resulting in a cascade:
Removing the dependency of:
...fixes the issue, and allows Composer to install everything (but then we don't have Rector installed)
Steps to reproduce
Additional info
^3.7.26& Craft CMS^4.0.0