craftcms / redactor

Edit rich text content in Craft CMS using Redactor by Imperavi.
https://plugins.craftcms.com/redactor
MIT License
100 stars 49 forks source link

"Indent" button not appearing #296

Closed cherrykoda closed 2 years ago

cherrykoda commented 3 years ago

Description

Adding "indent" to the buttons list does not work, however "outdent" does.

Steps to reproduce

  1. Add "indent" to the redactor config
  2. open an entry that's meant to use the config
  3. attempt to locate the indent button

image

image

Additional info

andris-sevcenko commented 3 years ago

I tested out this behavior and it's strange. "Indent" will actually put the "list" button there.

It almost makes sense - Redactor only allows indenting and outdenting list times and the button is actually a dropdown list that does contain the "indent" option.

I'm unsure as to why "outdent" would warrant a stand-alone button then, but this is not something that this plugin affects.

acres42 commented 3 years ago

Did this ever get solved? I am having a very similar issue with "lists" in the Standard.json file as well. Description Adding "lists" to the buttons list works for unordered lists and ordered lists, however the "indent" and "outdent" buttons remain disabled

Steps to reproduce Add "lists" to the redactor config open an entry that's meant to use the config click the lists button

Screen Shot 2021-06-30 at 9 43 23 AM Screen Shot 2021-06-30 at 9 52 51 AM

AS THE OP mentions above, I can get the Outdent button to show up by explicitly calling it in Standard.json, but it still does nothing if I click it, and explicitly calling the Indent button makes this show the lists button, but does not work.

Additional info Craft version: 3.5.14 PHP version: 7.4 Plugins & versions: Redactor 2.8.3 (with a shot at using 2.8.7, see below)

UPDATE I tried updating craftcms/redactor to 2.8.7, which seems to be the latest version. Good news is the Outdent button is enabled again, however, Indent is still disabled and not working

Screen Shot 2021-06-30 at 10 24 54 AM

andris-sevcenko commented 3 years ago

@acres42 this is something that Redactor itself does (you can test it here: https://imperavi.com/redactor) and modifying that behavior is out of scope for this plugin.

My observations include that it's not possible to indent the first list item, however, you can indent all the other list items.