Variant Sync only imports 50 variants

kragit commented 5 months ago

Description

It appears only 50 variants are being synced to products. This aligns with the default Shopify API response without a limit parameter.

/src/services/Api.php - Line 153 function getVariantsByProductId appears to use the get function, which does not modify the limit returned - API responses would return the default limit of 50.

On the other hand, /src/services/Api.php - Line 179 function getAll appears to have a params variable that is set to pull the max limit of 250 and then paginate, but this appears to be only used for Products, not Variants.

Steps to reproduce

Create a Shopify product with more than 50 variants
Observe the Variant list inside the Control Panel and the array returned with getVariants() only returns 50 values.

Additional info

Craft version: 5.1.7
PHP version: 8.3.7
Database driver & version: PostgreSQL 16.3
Plugins & versions: Shopify 5.1.1, Feed Me 6.0.1

linear[bot] commented 5 months ago

PT-1770 Variant Sync only imports 50 variants

nfourtythree commented 5 months ago

Hi @kragit

Thank you for raising this issue, we have been able to replicate it and therefore will look into getting a fix in place.

Thanks!

nfourtythree commented 5 months ago

Hi

Version 5.2.0 of the plugin has now been released with this fix/update included. If you have issues with rate limiting after this update we have added a --throttle option to the command line sync command which will make this initial sync slower but will ensure all data is sync'd into Craft.

Thanks!

craftcms / shopify