craftcms / shopify

Synchronize and extend product data from your Shopify storefront.
MIT License
45 stars 25 forks source link

Add `publishedScope` to product query #66

Closed johndwells closed 1 year ago

johndwells commented 1 year ago

This PR addresses #65 by adding publishedScope() to the ProductQuery.

johndwells commented 1 year ago

Actually, after this PR I only get 1 result returned if I specify publishedScope("web"), even though there are 39 in the database; however if I specify publishedScope("global"), then I get the same number as in the DB (1039).

I think there is something about the inner query that joins to the sites table. FWIW this is a multi-site. So I might be experiencing a separate bug, but I did want to flag in case this PR was somehow related!

lukeholder commented 1 year ago

Closing in favour of https://github.com/craftcms/shopify/commit/df126ea3705ed3717fddf1ef7dade9146056a990