search

craftcms / shopify

Synchronize and extend product data from your Shopify storefront.
MIT License
44 stars 25 forks source link

refHandle does not parse properly because of the dash #77

Closed nichxlson closed 8 months ago

nichxlson commented 10 months ago

Description

Redactor plugin doesn't parse the refHandle because of the dash.

Steps to reproduce

  1. Add a link in a redactor field in this format: https://example.com#shopify-products:[id]@1:url and save the entry
    • The link doesn't parse and goes to example.com
  2. Change the refHandle field in elements/Product.php from shopify-products to shopifyproducts
  3. Change the link in redactor to https://example.com#shopifyproducts:[id]@1:url and save the entry
  4. The link now parses properly and when you make changes where the product URI is updated the redactor field link will also update

Additional info

lukeholder commented 8 months ago

This has been fixed for the next release here: 9c74fb8e65be09f29dbcb267c9c2e01b270e1384. The ref handle has been changed to shopifyproduct. Will update this issue once 4.0 is out. Thanks.

lukeholder commented 8 months ago

4.0.0 is now out. Make sure to read the changelog item to learn what you need to do to upgrade. The readme also contains instructions.