Closed ryanpcmcquen closed 4 years ago
To test it locally use (in composer.json
):
"nmaier95/shopify-product-fetcher": "dev-add_support_for_link_pagination_and_filtering as 1.0.5"
And make sure you have this prop in there as well:
"repositories": [
{
"url": "https://github.com/OriginalFunko/craft-shopify-product-fetcher.git",
"type": "git"
}
],
@nmaier95, I added some new features as well, a Show selected only checkbox, and a Clear selected button:
@nmaier95, I added some more options to the settings menu (limit
and published_status
):
This has also been tested with: https://github.com/nmaier95/craft-shopify-product-fetcher/pull/10
Hi @ryanpcmcquen , any chance you can give me api credentials with like limited access rights or smth to your store? Unfortunately I dont have an active shopify account to test your pr with. I could open an trial account but it won't have quite as much products.
@nmaier95, unfortunately I cannot get approval for that. I can assure you that I thoroughly tested these changes and the QA team here did as well.
@ryanpcmcquen Ok then, thank you anyway. I have tested it with a trial version of shopify and it worked, as far as i can tell. Besides the js error i mentioned in my comments
@nmaier95, the JS issue has been resolved.
@nmaier95, all requested changes have been made.
This closes https://github.com/nmaier95/craft-shopify-product-fetcher/issues/8 and adds a filter box to dynamically filter products:
Signed-off-by: Ryan McQuen rmcquen@funko.com