search

craftcms / spoke-and-chain

Craft CMS + Craft Commerce demo site.
https://craftcms.com/demo?kind=spokeandchain
BSD Zero Clause License
54 stars 28 forks source link

Cypress tests not compatible with cypress 10.4.0 #128

Closed piotrpog closed 2 years ago

piotrpog commented 2 years ago

Today when i tried to run tests, it forced me to update to cypress 10.4.0 (the old version just would not run and only displayed update option in console - i dod not updated node, npm or modified package.json in any way).

With the new version of cypress, the naming scheme of tests changed (files now need to be named like testName.cy.js and be in e2e directory), cypress.json config file is no longer supported.

Also it seems that now browser console errors make tests fail, while earlier it did not seemed to be a case (i have console error of failing to load css chunk).

piotrpog commented 2 years ago

Just small update, cypress is not actually forcing me to update, it was because i tried to use globally installed version of cypress, not local one from installed in node_modules.

But the issue is still valid - tests are not updated to latest version of cypress. Are there any plans to update them?

piotrpog commented 2 years ago

One more issue.. it seems that using this old version of cypress (opr anything else that is included in package.json file) causes issues with node 16, and higher, at least on windows. Downgrading node do version 12 makes it work.

piotrpog commented 2 years ago

What is more, when we install node packages, we get this warning: added 2514 packages from 1011 contributors and audited 2522 packages in 1040.64s found 36 vulnerabilities (4 low, 13 moderate, 17 high, 2 critical)

nfourtythree commented 2 years ago

This was completed in the following PR: https://github.com/craftcms/spoke-and-chain/pull/132