craftcms / webhooks

Plugin for integrating Craft with Zapier and IFTTT.
https://plugins.craftcms.com/webhooks
MIT License
84 stars 12 forks source link

[3.2] afterSave webhook firing numerous times on "Save Entry" #16

Closed juliansthl closed 5 years ago

juliansthl commented 5 years ago

Description

After upgrading to 3.2 we're experiencing an issue that's quite troubling for us.

We configured a webhook to fire on afterSave for all entries.

When saving an entry it takes around 15 seconds for the Control Panel to respond. Afterwards our webhook is fired numerous times (around 30).

Here's a short demonstration: https://www.dropbox.com/s/2ts3vurna6xin9f/Bildschirmaufnahme%202019-07-26%20um%2011.28.45.mov?dl=0

btw. this also happens when the content remains unchanged between saves…

Webhook configuration: https://www.dropbox.com/s/ofsmcrv2pdav9kb/Screenshot%202019-07-26%2011.31.20.png?dl=0

We're using the Super Table plugin quite heavily. From my understanding this content is now also saved on an entry-basis – maybe that's why the hook is firing so many times?

Disabling the webhook makes the Control Panel respond much faster again (and of course doesn't add any webhooks to the queue).

Steps to reproduce

  1. Setup a webhook to fire afterSave on entries
  2. Make heavy us of the Super Table plugin on an Entry
  3. Save the entry

Additional info

juliansthl commented 5 years ago

Using craft\elements\Entry instead of craft\base\Entry as the sender class for the webhook does not make any difference.

brandonkelly commented 5 years ago

Duplicate of #13

brandonkelly commented 5 years ago

(And now resolved as of Webhooks 2.1.0 – see #14.)