craftcms / webhooks

Plugin for integrating Craft with Zapier and IFTTT.
https://plugins.craftcms.com/webhooks
MIT License
84 stars 12 forks source link

Failed webhook calls block further calls #35

Closed joshuabaker closed 3 years ago

joshuabaker commented 4 years ago

Description

We’ve got a headless Craft install that triggers a build in Vercel. Due to our using a debounce key, if there’s an issue with a request the system gets stuck ‘Pending’ forever, with all subsequent requests dropped as they also match the debounce key.

image

Steps to reproduce

Obviously hard to reproduce, however, simulating the pending state whilst using a debounce key might be possible.

Additional info

joshuabaker commented 4 years ago

I’m closing this as we’ve not encountered it again.

daltonrooney commented 4 years ago

@joshuabaker Could you re-open this? I believe I'm experiencing the same issue:

Screen Shot 2020-08-21 at 12 05 04 PM

Also the "clear" button doesn't work, so there's no way for me to run a new execution without changing or removing the debounce key.

Craft CMS 3.5.5 Webhooks 2.3.2

weotch commented 3 years ago

I also am experiencing this:

image

Image 2021-06-07 at 10 28 08 AM

carlcs commented 3 years ago

We’re also running into this. Now trying with a dynamic debounce key {{ now|date('i') }} instead of deploy, which we’ve had before.

brandonkelly commented 3 years ago

Webhooks 2.4 is out now, which adds a new “Send now” button for pending webhook requests, beside their status in the request details view.

It also fixes an exception that occurred when initially attempting to send the request, if a connection with the server couldn’t be established, which would result in the job getting marked as failed, but leave the request stuck in its pending state – which is possibly how you’re ending up with so many pending requests to begin with.

weotch commented 2 years ago

That "Send now" button helps, but it's not an optimal solution IMO because it requires someone to notice that the webhook failed.

I'd love auto-retry or auto-clear functionality for stuck webhook invocations.

davidhellmann commented 2 years ago

Running into the same issue. All pending :/

howells commented 5 months ago

I'd love a way to retry all pending web hooks. I have about 1000 that are pending for some reason.

howells commented 1 month ago

@brandonkelly wondered if there could be any update to this? I've tried making my own command to re-try all pending requests but I'm really struggling