Local Shopify 404 prefetching hangs

wiebekaai commented 6 months ago

Describe the bug Working with Shopify locally, prefetching 404s throws a JavaScript error without displaying the 404 page to the user. On production it works as expected and skips the transition, bringing you to the 404 page.

From my screenshots, the issue seems to be related to the way Shopify handles tracking (Web Pixel Manager). I'd be happy to show you an example setup in a screen share.

To Reproduce Steps to reproduce the behavior:

Configure transition with removeOldContent: false and bypassCache: true (remove old content in onEnterCompleted()).
Use the Shopify CLI to start a project.
Browse to the locally hosted Shopify theme (http://127.0.0.1:9292)
Hover a 404 link.
Click the link.
The onLeave transition is triggered, but it does not navigate to the 404 page.

Info

Device: Macbook
OS: macOS Sonoma
Browser: Chrome
Version: 122

Follow up of https://github.com/craftedbygc/taxi/issues/21

jakewhiteley commented 6 months ago

Could I ask which taxi version this is? I assume the most recent

wiebekaai commented 6 months ago

Could I ask which taxi version this is? I assume the most recent

Yes. Tried to reproduce and doesn't seem to happen anymore. Maybe I tried with a cached version before. Thanks again :).

craftedbygc / taxi

Local Shopify 404 prefetching hangs #22