[studio] Publishing renamed/moved item does not clean old path from published sandbox

dejan-brkic commented 6 years ago

Expected behavior

Publishing renamed/moved item should publish item at new location and delete it from old location

Actual behavior

Publishing renamed/moved item does not delete file from the old location

Steps to reproduce the problem

Create site from editorial BP
Rename existing page
Publish page
Error: file on the old location in published sandbox is not deleted

Log/stack trace (use https://gist.github.com)

No errors in start trace

Specs: version, OS, browser, etc.

Latest version, all OS, all browsers

dejan-brkic commented 6 years ago

Done PR: https://github.com/craftercms/studio/pull/988

sumerjabri commented 6 years ago

There is still an issue. Steps:

Create a site using editorial bp
Rename /articles/2017 to /articles/2017-2
From the dashboard, show in-progress items and publish all articles
On disk, go to published and run the command diff -r --exclude ".git" . ../sandbox and you'll see:
```
Only in ./site/website/articles: 2017
```

Looking into what's in 2017, you'll find the old content still there.

dejan-brkic commented 6 years ago

Done PR: https://github.com/craftercms/studio/pull/998

sumerjabri commented 6 years ago

Same steps to reproduce. Here is what I see on disk:

sumer@xinu:/home/sumer/code/crafter/craftercms/crafter-authoring/data/repos/sites/asdf  git:(develop) $ find . -name '2017*'
./published/site/website/articles/2017-2
./published/site/website/articles/2017
./sandbox/site/website/articles/2017-2

published/site/website/articles/2017
├── 1
│   ├── men-styles-for-winter
│   │   └── index.xml
│   └── women-styles-for-winter
│       └── index.xml
├── 2
│   ├── 10-tips-to-get-a-six-pack
│   │   └── index.xml
│   └── top-romantic-valentine-movies
│       └── index.xml
└── 3
    ├── 5-popular-diets-for-women
    │   └── index.xml
    └── top-clubs-in-virginia
        └── index.xml

9 directories, 6 files

dejan-brkic commented 6 years ago

Can not reproduce it with steps described above

Studio Version Number: 3.0.4-SNAPSHOT-b41cd2
Build Number: b41cd226e1ffef32ccf6971a2d217d569d078451

dejan-brkic commented 6 years ago

➜  published git:(live) tree site/website/articles
site/website/articles
├── 2016
│   ├── 12
│   │   └── top-books-for-young-women
│   │       └── index.xml
│   ├── 6
│   │   └── coffee-is-good-for-your-health
│   │       └── index.xml
│   └── 7
│       └── new-acme-phone-released-today
│           └── index.xml
├── 2017-2
│   ├── 1
│   │   ├── men-styles-for-winter
│   │   │   └── index.xml
│   │   └── women-styles-for-winter
│   │       └── index.xml
│   ├── 2
│   │   ├── 10-tips-to-get-a-six-pack
│   │   │   └── index.xml
│   │   └── top-romantic-valentine-movies
│   │       └── index.xml
│   └── 3
│       ├── 5-popular-diets-for-women
│       │   └── index.xml
│       └── top-clubs-in-virginia
│           └── index.xml
└── crafter-level-descriptor.level.xml

17 directories, 10 files
➜  published git:(live) cd ..
➜  craftercms1709i git:(develop) ✗ pwd
/Users/dejanbrkic/CrafterSoftware/craftercms/crafter-authoring/data/repos/sites/craftercms1709i
➜  craftercms1709i git:(develop) ✗ find . -name '2017*'
./sandbox/site/website/articles/2017-2
./published/site/website/articles/2017-2
➜  craftercms1709i git:(develop) ✗

craftercms / craftercms