craftercms / craftercms

Parent project for Crafter CMS. Issue tracking across all repositories and global builds.
GNU General Public License v3.0
288 stars 98 forks source link

[search] Creating Site spinner does not go away when creating a site from a bp with remote assets #3152

Closed alhambrav closed 5 years ago

alhambrav commented 5 years ago

Describe the bug

Creating Site spinner does not go away when creating a site from a bp without graphql

To Reproduce

Steps to reproduce the behavior:

  1. Start Studio
  2. Install your bp without graphql by following the steps here: https://docs.craftercms.org/en/3.1/developers/cook-books/blueprint/index.html You will need to create a craftercms-plugin.yaml file, the images are optional. (You can copy the craftercms-plugin.yaml file from one of the default bp, say, the empty bp and modify it for your bp). Remember to create your craftercms-plugin.yaml file first before adding and committing your new bp files
  3. In Studio, click on Create Site and select the newly installed bp
  4. Look in the logs and notice the exception:
    Error building the GraphQL schema for site 'yoursite'

    Notice also that the Creating Site spinner does not go away even if you wait for a while.

Screen Shot 2019-05-20 at 10 46 57 AM

Refresh you browser and notice that your site is created.

Expected behavior

The Creating Site spinner should go away after the site is created

Screenshots

{{If applicable, add screenshots to help explain your problem.}}

Logs

Here's the stack trace of the exception which is expected since the bp does not have graphql: https://gist.github.com/alhambrav/bb15af58c767f891946af8450d587fee

Specs

Version

Studio Version Number: 3.1.1-SNAPSHOT-e7cdd1 Build Number: e7cdd1c16932518745bf73e9f48740e802efe595 Build Date/Time: 05-20-2019 10:18:15 -0400

OS

OS X

Browser

Chrome browser

Additional context

{{Add any other context about the problem here.}}

alhambrav commented 5 years ago

Ping me for more info

alhambrav commented 5 years ago

Here's the response for create.json: Screen Shot 2019-05-23 at 9 49 46 AM

vestrada commented 5 years ago

image

vestrada commented 5 years ago

Ui is waiting 10 mins to get the response this is why the spinner seems to goes for ever. Dejan please verify if something is happening trough BE to take so much time. Vita is going to comment the size of the BP.

alhambrav commented 5 years ago

Hi! I checked the size of the blueprint and it says 58.1 MB, whereas the website editorial bp is 10.8 MB

dejan-brkic commented 5 years ago
Studio Version Number: 3.1.1-SNAPSHOT-35a73c

Build Number: 35a73c9c57acb78bc685cce83c9bafb187f1e52d

Create site does not spin for a long time. The error message is still in the logs but it is not coming from the studio. It is coming from the preview engine.

sumerjabri commented 5 years ago

@alhambrav I'm unable to reproduce. Ping me if you'd like me to demo.

sumerjabri commented 5 years ago

@jdrossl I can show you how to reproduce this. GraphQL shouldn't be trying to build the schema for a Solr site. Let's discuss.

jdrossl commented 5 years ago

@sumerjabri the spinner issue is caused because the deployer is indexing remote files from Box and there is an error there, I will send a fix for that.

The GraphQL error log is caused by a content error in the blueprint, we have no issue building the schema even if the site uses Solr, but if we want to change that maybe we should file a ticket with the new requirements for that.

sumerjabri commented 5 years ago

@jdrossl please send a PR to fix the BP problem as well.

jdrossl commented 5 years ago

@alhambrav there are also changes in the blueprint to fix some of the issues, so please update it in your global repo for testing

alhambrav commented 5 years ago

Verified fixed.