search

craftpip / angular-confirm

A multipurpose plugin for alert, confirm & dialog for angular1
http://craftpip.github.io/angular-confirm/
MIT License
115 stars 20 forks source link

It would be great if you guys start developing a version for angular 4x #11

Open sairam0903 opened 7 years ago

thanhdevapp commented 7 years ago

one vote, pls

developerslearnit commented 7 years ago

It will be very great

craftpip commented 7 years ago

thanks for the support, i will be starting on it shortly 👍

akurutin commented 7 years ago

one vote, pls

craftpip commented 7 years ago

What should i name it ? angular2-confirm ? angular4-confirm ? suggestions please

akurutin commented 7 years ago

Depends on compatibility If with both(2 and 4) - angular 2; else angular 4

smasherprog commented 7 years ago

angular 2-4 is now known as just angular

angular1 is referred to as angularjs

so this library should be called angularjs-confirm

the angular2 and up should be called angular-confirm

The above follows the angular naming conventions

Another option alot of people use is the prefix of ng2 ng2-confirm would work as well, but would be different then your current naming.

In any case, I would love an angular version of this! angular4 that is

albertoVieiraNeto commented 7 years ago

+1

vanditamathur commented 7 years ago

Looking forward to the Angular 4 version of this. What is the expected timeline?

craftpip commented 7 years ago

I need suggestions from you guys on this,

Idea: Originally my goal was to implement this plugin in such a way that you can render Components in side of the modal.

Problem: Angular has been changing its Api's rapidly for dynamic component loading. Which has changed a lot since angular2 final was released, i.e. Component loading is different in angular 2 and 4. Developing an angular version of this plugin and making it stable will take more time.

Solution: My suggestion is that have a angular service for the original jquery-confirm project, which will bring jquery as an dependency, but will give this project a longer life and keep it stable with all angular versions, Is it okay?

Please let me know what you think.

vanditamathur commented 7 years ago

jquery as a dependency should be fine.

kolte commented 7 years ago

I just love this plugin, it's the simplest and the best I have ever used. Re. Angular 2/4 It is very much stable now, no drastic changes that can break the plugin entirely. have you created this plugin for angular 2/4 already?