craftr-build / craftr-build-4.x

Frontend for the Craftr build framework.
https://craftr-build.github.io/craftr/
Other
60 stars 14 forks source link

broken (?) implicit_deps expansion #173

Closed mcquay239 closed 6 years ago

mcquay239 commented 7 years ago

Hi Niklas! Thank you for craftr :)

There is a strange genalias behavior: I generated several explicit targets with aliases and created an implicit all alias for them like

explicit_1 = generate(..., name="alias_1", explicit=True)
explicit_2 = generate(..., name="alias_2", explicit=True)
...
all = genalias(explicit_1, explicit_2, ..., name="all")

You don't generate phony rules for explicit targets and the all target becomes inconsistent. I worked around it with something like

all = genalias(*(explicit_1.outputs + explicit_2.outputs + ...), name="all")

But maybe the right way is to switch the mode in expanding mixed list (core/build.py:276)?

NiklasRosenstein commented 6 years ago

Closing as irrelevant for Craftr 4.