search

craftsmancoding / assetmanager

Asset Manager for MODX Revolution
36 stars 15 forks source link

Removing Builds #64

Closed jpdevries closed 9 years ago

jpdevries commented 9 years ago

It takes a while to check this project out in git because all the transport packages within the version control. This PR suggests a workflow of tagging releases with git tag and then uploading the transport package to the associated tag.

Closes craftsmancoding/assetmanager#63

fireproofsocks commented 9 years ago

Hmm... maybe a better option would be a dedicated "builds" branch, since the tagging of a commit would follow slightly different behavior in traditional composer packages. The only reason those builds are there in the first place was because of repeated problems uploading packages to MODX's package repo...

jpdevries commented 9 years ago

I can't think of any reason for zips to be under version control...

That's what tags are for and files can be attached to tagged releases. 

For example notice the tranport zip is attached to this release:

https://github.com/modmore/CodeMirror/releases/tag/2.3.0-dev

— Sent from Mailbox

On Fri, Jul 3, 2015 at 7:55 AM, Everett Griffiths notifications@github.com wrote:

Hmm... maybe a better option would be a dedicated "builds" branch, since the tagging of a commit would follow slightly different behavior in traditional composer packages. The only reason those builds are there in the first place was because of repeated problems uploading packages to MODX's package repo...

Reply to this email directly or view it on GitHub: https://github.com/craftsmancoding/assetmanager/pull/64#issuecomment-118368686

fireproofsocks commented 9 years ago

Again: the reason they were there is so people could download the latest version when uploading the zips to the MODX repo was failing for unknown reasons. Granted, that doesn't belong under version control, but it makes sense to keep related files under the same roof.

fireproofsocks commented 9 years ago

I see what you mean -- yeah, that's a cleaner way.

jpdevries commented 9 years ago

If they are on Github, it's pretty much under the same roof. For example, could have a releases list of links to tags in the README. 

— Sent from Mailbox

On Fri, Jul 3, 2015 at 8:07 AM, Everett Griffiths notifications@github.com wrote:

I see what you mean -- yeah, that's a cleaner way.

Reply to this email directly or view it on GitHub: https://github.com/craftsmancoding/assetmanager/pull/64#issuecomment-118370401