search

craftsmancoding / assetmanager

Asset Manager for MODX Revolution
36 stars 15 forks source link

Asset Manager 1.3.0 does not work with ModX 2.6.5 #90

Closed mediengaarage closed 5 years ago

mediengaarage commented 5 years ago

The Asset Manager 1.3.0 does not work with ModX 2.6.5 after update. PHP 7.2

Mark-H commented 5 years ago

This will need more information - what doesn't work? What errors do you get?

mediengaarage commented 5 years ago

Sorry, here more informations.

The imagelist doesn't display anything.

Error:

[2018-09-18 10:04:08] (ERROR @ /.../core/components/assman/model/assman/asset.class.php : 724) PHP warning: Invalid argument supplied for foreach()

Code line 724 of asset.class.php:

721  public function getFilters($array)
722    {
723        //file_put_contents('/paas/c0010/www/core/cache/logs/debug.txt', print_r($array,true), FILE_APPEND);
724        foreach ($this->control_params as $p) {
725            unset($array[$p]);
726        }

Here my snippet call:

[[getPageAssets? 
    &innerTpl=`sliderTpl`
    &is_image=`1`
    &outerTpl=``
]]

chunk "sliderTpl":

<img alt="[[+Asset.title]]" src="[[+Asset.url:phpthumbof=`w=120`]]"
                data-image="[[+Asset.url:phpthumbof=`w=1200`]]"
                data-description="[[+Asset.alt]]">

Here the url to the site: https://schreinerei-weingartner.de/moebel.html There should be a slider under the headline

fireproofsocks commented 5 years ago

A fix for compatibility with MODX 2.6.5 has been to the master branch and is being released as version 1.3.1