search

craftsmancoding / repoman

Repoman allows for easy package development in MODX Revolution. Take back the simplicity!
30 stars 7 forks source link

Running update nukes values for system settings #19

Closed fireproofsocks closed 10 years ago

fireproofsocks commented 10 years ago

To reproduce, try installing Repoman via Repoman (clone the repo, do composer install, then repoman install). On the CMP, set the repoman.dir setting to "repos/" or some such. Save the page. Then back on the command line, run "php repoman update ."

Expected result is that system settings remain unchanged.

Actual result is that the update nukes the system setting value.

fireproofsocks commented 10 years ago

Fixed in the composer.json build attributes:

"build_attributes":{
        "modSystemSetting": {
           "unique_key": "key",
           "preserve_keys": true,
           "update_object": false
        }
    }

update_object needs to be false, otherwise system settings get updated to whatever the package ships with.

47e8549..afd3383 master -> master